linux-kernel - Re: [PATCH v2 2/3] leds: ktd2692: add device tree bindings for ktd2692

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <5508D65F.7070301@samsung.com>
Date:	Wed, 18 Mar 2015 10:35:27 +0900
From:	Ingi Kim <ingi2.kim@...sung.com>
To:	Jaehoon Chung <jh80.chung@...sung.com>
Cc:	cooloney@...il.com, rpurdie@...ys.net, robh+dt@...nel.org,
	pawel.moll@....com, mark.rutland@....com,
	ijc+devicetree@...lion.org.uk, galak@...eaurora.org,
	sakari.ailus@....fi, j.anaszewski@...sung.com,
	varkabhadram@...il.com, sw0312.kim@...sung.com,
	cw00.choi@...sung.com, ideal.song@...sung.com,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH v2 2/3] leds: ktd2692: add device tree bindings for ktd2692

Hi

On 2015년 03월 18일 07:40, Jaehoon Chung wrote:
> On 03/17/2015 05:45 PM, Ingi Kim wrote:
>> This patch adds the device tree bindings for ktd2692 flash LEDs.
>> Add optional properties 'flash-timeout-us' to control flash timeout
>> and 'vin-supply' for flash-led regulator
>>
>> Signed-off-by: Ingi Kim <ingi2.kim@...sung.com>
>> ---
>>  .../devicetree/bindings/leds/leds-ktd2692.txt      | 37 ++++++++++++++++++++++
>>  1 file changed, 37 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-ktd2692.txt b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>> new file mode 100644
>> index 0000000..1b44225
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/leds/leds-ktd2692.txt
>> @@ -0,0 +1,37 @@
>> +* Kinetic Technologies - KTD2692 Flash LED Driver
>> +
>> +KTD2692 is the ideal power solution for high-power flash LEDs.
>> +It uses ExpressWire single-wire programming for maximum flexibility.
>> +
>> +The ExpressWire interface through CTRL pin can control LED on/off and
>> +enable/disable the IC, Movie/Flash mode current, Flash timeout,
>> +LVP(low voltage protection).
>> +
>> +Required properties:
>> +	- compatible: "kinetic,ktd2692"
>> +	- ctrl-gpio : gpio pin in order control ktd2692 flash led.
>> +		There is an internal 300kOhm pull-down resistor at this pin
>> +	- supply : "vin" LED supply
>> +
>> +Optional property:
>> +	- flash-timeout-us : Maximum flash timeout in microseconds.
>> +			flash timeout ranges from 0 to 1835000us and
>> +			default is 1049000us.
>> +
>> +Example:
>> +
>> +vbat: fixedregulator@0 {
>> +	compatible = "regulator-fixed";
>> +	regulator-name = "vbat-supply";
>> +	regulator-min-microvolt = <5000000>;
>> +	regulator-max-microvolt = <5000000>;
>> +	gpio = <>;
> 
> gpio = <> ? What do you mean?
> And this is described at Documentation/devicetree/bindings/regulator/fixed-regulator.txt
> I'm not sure whether this example really needs.
> 
> Best Regards,
> Jaehoon Chung
> 

I just want to show that dummy regulator can be used with flash-led.
As you mentioned earlier, remove unnecessary example and add refer comment 

Thanks,
Ingi Kim

>> +	regulator-always-on;
>> +};
>> +
>> +flash-led {
>> +	compatible = "kinetic,ktd2692";
>> +	ctrl-gpio = <&gpc0 1 0>;
>> +	flash-timeout-us = <1835000>;
>> +	vin-supply = <&vbat>;
>> +};
>>
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/