linux-kernel - Re: [PATCH/RFC v13 10/13] Documentation: leds: Add description of v4l2-flash sub-device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <55098D55.6050101@samsung.com>
Date:	Wed, 18 Mar 2015 15:36:05 +0100
From:	Jacek Anaszewski <j.anaszewski@...sung.com>
To:	Sakari Ailus <sakari.ailus@....fi>, cooloney@...il.com
Cc:	linux-leds@...r.kernel.org, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
	kyungmin.park@...sung.com, pavel@....cz, rpurdie@...ys.net,
	s.nawrocki@...sung.com
Subject: Re: [PATCH/RFC v13 10/13] Documentation: leds: Add description of
 v4l2-flash sub-device

Hi Sakari,

On 03/18/2015 01:39 PM, Sakari Ailus wrote:
> Hi Jacek,
>
> On Thu, Mar 12, 2015 at 04:45:11PM +0100, Jacek Anaszewski wrote:
>> This patch extends LED Flash class documention by
>> the description of interactions with v4l2-flash sub-device.
>>
>> Signed-off-by: Jacek Anaszewski <j.anaszewski@...sung.com>
>> Acked-by: Kyungmin Park <kyungmin.park@...sung.com>
>> Acked-by: Sakari Ailus <sakari.ailus@....fi>
>> Cc: Bryan Wu <cooloney@...il.com>
>> Cc: Richard Purdie <rpurdie@...ys.net>
>> ---
>>   Documentation/leds/leds-class-flash.txt |   13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/Documentation/leds/leds-class-flash.txt b/Documentation/leds/leds-class-flash.txt
>> index 19bb673..8623413 100644
>> --- a/Documentation/leds/leds-class-flash.txt
>> +++ b/Documentation/leds/leds-class-flash.txt
>> @@ -20,3 +20,16 @@ Following sysfs attributes are exposed for controlling flash LED devices:
>>   	- max_flash_timeout
>>   	- flash_strobe
>>   	- flash_fault
>> +
>> +A LED subsystem driver can be controlled also from the level of VideoForLinux2
>> +subsystem. In order to enable this CONFIG_V4L2_FLASH_LED_CLASS symbol has to
>> +be defined in the kernel config. The driver must call the v4l2_flash_init
>> +function to get registered in the V4L2 subsystem. On remove the
>> +v4l2_flash_release function has to be called (see <media/v4l2-flash.h>).
>> +
>> +After proper initialization a V4L2 Flash sub-device is created. The sub-device
>> +exposes a number of V4L2 controls, which allow for controlling a LED Flash class
>
> Over 80 characters per line.

This line has exactly 80 characters, probably you checked the
length in the patch, which includes leading '+' character.

>
> With this fixed,
>
> Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

Probably I inadvertently changed the Acked-by email.
Bryan, please apply the patch with:

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

>
>> +device with use of its internal kernel API.
>> +Opening the V4L2 Flash sub-device makes the LED subsystem sysfs interface
>> +unavailable. The interface is re-enabled after the V4L2 Flash sub-device
>> +is closed.
>


-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/