linux-kernel - Re: [PATCH v2] phy: Add a driver for dm816x USB PHY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2015 07:56:33 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, Bin Liu <binmlist@...il.com>,
	Brian Hutchinson <b.hutchman@...il.com>,
	Felipe Balbi <balbi@...com>,
	Matthijs van Duin <matthijsvanduin@...il.com>,
	Rusty Russell <rusty@...tcorp.com.au>
Subject: Re: [PATCH v2] phy: Add a driver for dm816x USB PHY

* Paul Bolle <pebolle@...cali.nl> [150318 04:13]:
> Two trivialities I failed the spot the first time.
> 
> On Tue, 2015-03-17 at 17:12 -0700, Tony Lindgren wrote:
> > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> > index 2962de2..c858c2b 100644
> > --- a/drivers/phy/Kconfig
> > +++ b/drivers/phy/Kconfig
> 
> > +config PHY_DM816X_USB
> > +	tristate "TI dm816x USB PHY driver"
> > +	depends on ARCH_OMAP2PLUS
> > +	select GENERIC_PHY
> > +	help
> > +	  Enable this for dm81xx USB to work."
> > +
> 
> A trailing double quote.

Oops thanks for spotting that, will remove.
 
> > --- /dev/null
> > +++ b/drivers/phy/phy-dm816x-usb.c
> 
> > +MODULE_ALIAS("platform: dm816x_usb");
> 
> That space looks odd. Will it be removed by scripts/mod/file2alias.c? Or
> will it end up in the mdule, in modules.alias, and presumably break
> something (I'm not sure what, actually)?
> 
> There are currently six other instances MODULE_ALIAS() that have a space
> there. That would mean they're all broken, somehow, which would be
> unlikely, so I guess it's just a stylistic nit.

That looks like copy paste error, will fix. It seems like a style issue,
there's commit dd64ad387cc0 ("phy: ti/omap: Fix modalias") fixing those
up for drivers/phy.

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/