linux-kernel - Re: [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150318165414.GA25477@psi-dev26.jf.intel.com>
Date:	Wed, 18 Mar 2015 09:54:14 -0700
From:	David Cohen <david.a.cohen@...ux.intel.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Baolu Lu <baolu.lu@...ux.intel.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Kishon Vijay Abraham I <kishon@...com>
Subject: Re: [PATCHv2 11/12] phy: helpers for USB ULPI PHY registering

On Wed, Mar 18, 2015 at 05:46:44PM +0300, Sergei Shtylyov wrote:
> Hello.
> 
> On 3/18/2015 3:40 PM, Heikki Krogerus wrote:
> 
> >ULPI PHYs need to be bound to their controllers with a
> >lookup. This adds helpers that the ULPI drivers can use to
> >do both, the registration of the PHY and the lookup, at the
> >same time.
> 
> >Signed-off-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> >Cc: Kishon Vijay Abraham I <kishon@...com>
> >---
> >  drivers/phy/ulpi_phy.h | 31 +++++++++++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
> >  create mode 100644 drivers/phy/ulpi_phy.h
> 
> >diff --git a/drivers/phy/ulpi_phy.h b/drivers/phy/ulpi_phy.h
> >new file mode 100644
> >index 0000000..ac49fb6
> >--- /dev/null
> >+++ b/drivers/phy/ulpi_phy.h
> >@@ -0,0 +1,31 @@
> >+#include <linux/phy/phy.h>
> >+
> >+/**
> >+ * Helper that registers PHY for a ULPI device and adds a lookup for binding it
> >+ * and it's controller, which is always the parent.
> >+ */
> >+static inline struct phy
> >+*ulpi_phy_create(struct ulpi *ulpi, struct phy_ops *ops)
> 
>    Please either keep the prototype on a single line or don't break it like
> this. The result type should be all on the 1st line.

IMHO this is quite fine and readable. We can find this style in many
places of the kernel.
Maybe it's a matter of taste :)

BR, David

> 
> [...]
> 
> WBR, Sergei
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/