linux-kernel - Re: [PATCH] octeon-usb: fix 'too many leading tabs'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150318182633.GC10043@fuloong-minipc.musicnaut.iki.fi>
Date:	Wed, 18 Mar 2015 20:26:33 +0200
From:	Aaro Koskinen <aaro.koskinen@....fi>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org
Subject: Re: [PATCH] octeon-usb: fix 'too many leading tabs'

Hi,

On Wed, Mar 18, 2015 at 10:18:29PM +0530, Amitoj Kaur Chawla wrote:
> This file contained a lot of warnings of line of over 80 characters
> and that the code needs to be refactored due to nested if else
> conditions.
> 
> The file was accordingly edited to remove some of the warnings.
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> ---
>  drivers/staging/octeon-usb/octeon-hcd.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c
> index c8df0c3..e944292 100644
> --- a/drivers/staging/octeon-usb/octeon-hcd.c
> +++ b/drivers/staging/octeon-usb/octeon-hcd.c
> @@ -2920,11 +2920,11 @@ static int __cvmx_usb_poll_channel(struct cvmx_usb_state *usb, int channel)
>  					 */
>  					if (!usbc_hcchar.s.epdir) {
>  						if (buffer_space_left < pipe->max_packet)
> -							transaction->actual_bytes +=
> -								buffer_space_left;
> +						    transaction->actual_bytes +=
> +							      buffer_space_left;
>  						else
> -							transaction->actual_bytes +=
> -								pipe->max_packet;
> +						    transaction->actual_bytes +=
> +							       pipe->max_packet;

You could reduce deep indentation here by moving the whole ACK bit
handling into a separate function.

A.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/