linux-kernel - Re: [PATCH V2 4/4] hugetlbfs: document min

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150318144108.e235862e0be30ff626e01820@linux-foundation.org>
Date:	Wed, 18 Mar 2015 14:41:08 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mike Kravetz <mike.kravetz@...cle.com>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Davidlohr Bueso <dave@...olabs.net>,
	Aneesh Kumar <aneesh.kumar@...ux.vnet.ibm.com>,
	Joonsoo Kim <iamjoonsoo.kim@....com>
Subject: Re: [PATCH V2 4/4] hugetlbfs: document min_size mount option

On Mon, 16 Mar 2015 16:53:29 -0700 Mike Kravetz <mike.kravetz@...cle.com> wrote:

> Update documentation for the hugetlbfs min_size mount option.
> 
> Signed-off-by: Mike Kravetz <mike.kravetz@...cle.com>
> ---
>  Documentation/vm/hugetlbpage.txt | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/vm/hugetlbpage.txt b/Documentation/vm/hugetlbpage.txt
> index f2d3a10..83c0305 100644
> --- a/Documentation/vm/hugetlbpage.txt
> +++ b/Documentation/vm/hugetlbpage.txt
> @@ -267,8 +267,8 @@ call, then it is required that system administrator mount a file system of
>  type hugetlbfs:
>  
>    mount -t hugetlbfs \
> -	-o uid=<value>,gid=<value>,mode=<value>,size=<value>,nr_inodes=<value> \
> -	none /mnt/huge
> +	-o uid=<value>,gid=<value>,mode=<value>,size=<value>,min_size=<value>, \
> +	nr_inodes=<value> none /mnt/huge
>  
>  This command mounts a (pseudo) filesystem of type hugetlbfs on the directory
>  /mnt/huge.  Any files created on /mnt/huge uses huge pages.  The uid and gid
> @@ -277,11 +277,18 @@ the uid and gid of the current process are taken.  The mode option sets the
>  mode of root of file system to value & 01777.  This value is given in octal.
>  By default the value 0755 is picked. The size option sets the maximum value of
>  memory (huge pages) allowed for that filesystem (/mnt/huge). The size is
> -rounded down to HPAGE_SIZE.  The option nr_inodes sets the maximum number of
> -inodes that /mnt/huge can use.  If the size or nr_inodes option is not
> -provided on command line then no limits are set.  For size and nr_inodes
> -options, you can use [G|g]/[M|m]/[K|k] to represent giga/mega/kilo. For
> -example, size=2K has the same meaning as size=2048.
> +rounded down to HPAGE_SIZE.  The min_size option sets the minimum value of
> +memory (huge pages) allowed for the filesystem.  Like the size option,
> +min_size is rounded down to HPAGE_SIZE.  At mount time, the number of huge
> +pages specified by min_size are reserved for use by the filesystem.  If
> +there are not enough free huge pages available, the mount will fail.  As
> +huge pages are allocated to the filesystem and freed, the reserve count
> +is adjusted so that the sum of allocated and reserved huge pages is always
> +at least min_size.  The option nr_inodes sets the maximum number of
> +inodes that /mnt/huge can use.  If the size, min_size or nr_inodes option
> +is not provided on command line then no limits are set.  For size, min_size
> +and nr_inodes options, you can use [G|g]/[M|m]/[K|k] to represent
> +giga/mega/kilo. For example, size=2K has the same meaning as size=2048.

Nowhere here is the reader told the units of "size".  We should at
least describe that, and maybe even rename the thing to min_bytes.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/