lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.02.1503182345290.2193@localhost6.localdomain6>
Date:	Wed, 18 Mar 2015 23:46:07 +0100 (CET)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Patrick Farrell <paf@...y.com>
cc:	py@...48-systeme.lip6.fr, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	Julia.Lawall@...6.fr,
	Pierre-Yves PĂ©neau <pierre-yves.peneau@....com>,
	viro@...iv.linux.org.uk, aybuke.147@...il.com,
	HPDD-discuss@...1.01.org
Subject: Re: [HPDD-discuss] [PATCH] Staging: lustre: file.c: fix coding
 style

On Wed, 18 Mar 2015, Patrick Farrell wrote:

> Uck, my reply made the formatting even worse.  I'm trying to say it should
> look like this:
> +            rc = ll_intent_file_open(file->f_path.dentry,
> +                                                    NULL, 0, it);
> Not like this:
> +            rc = ll_intent_file_open(file->f_path.dentry,
> +                                                   NULL, 0, it);

Both look wrong to me.  Are your tabs equivalent to 8 spaces?

julia

> 
> On 03/18/2015 02:31 PM, Patrick Farrell wrote:
> > Perhaps this is just a formatting error in my email client, but shouldn't
> > NULL be one more space over to line up with the '(' above?
> > 
> > On 03/18/2015 02:08 PM, py@...48-systeme.lip6.fr wrote:
> > > +            rc = ll_intent_file_open(file->f_path.dentry,
> > > +                        NULL, 0, it);
> > 
> > _______________________________________________
> > HPDD-discuss mailing list
> > HPDD-discuss@...ts.01.org
> > https://lists.01.org/mailman/listinfo/hpdd-discuss
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ