linux-kernel - perf: thread is its own parent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 18 Mar 2015 17:56:33 -0600
From:	David Ahern <dsahern@...il.com>
To:	Don Zickus <dzickus@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Jiri Olsa <jolsa@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: perf: thread is its own parent

Don:

In this commit:

commit 363b785f3805a2632eb09a8b430842461c21a640
Author: Don Zickus <dzickus@...hat.com>
Date:   Fri Mar 14 10:43:44 2014 -0400

     perf tools: Speed up thread map generation

you made a thread its own parent when synthesizing fork events:

static int perf_event__synthesize_fork(struct perf_tool *tool,
                                        union perf_event *event, pid_t pid,
                                        pid_t tgid, 
perf_event__handler_t process,
                                        struct machine *machine)
{
         memset(&event->fork, 0, sizeof(event->fork) + 
machine->id_hdr_size);

         event->fork.ppid = tgid;
         event->fork.ptid = tgid;
         event->fork.pid  = tgid;
         event->fork.tid  = pid;
         event->fork.header.type = PERF_RECORD_FORK;


Any particular reason or just an oversight?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/