linux-kernel - [PATCH] [RFC] mm/compaction: initialize compaction information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1426743031-30096-1-git-send-email-gioh.kim@lge.com>
Date:	Thu, 19 Mar 2015 14:30:31 +0900
From:	Gioh Kim <gioh.kim@....com>
To:	akpm@...ux-foundation.org, vbabka@...e.cz, rientjes@...gle.com,
	iamjoonsoo.kim@....com, mgorman@...e.de
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	gunho.lee@....com, Gioh Kim <gioh.kim@....com>
Subject: [PATCH] [RFC] mm/compaction: initialize compaction information

I tried to start compaction via /proc/sys/vm/compact_memory
as soon as I turned on my ARM-based platform.
But the compaction didn't start.
I found some variables in struct zone are not initalized.

I think zone->compact_cached_free_pfn and some cache values for compaction
are initalized when the kernel starts compaction, not via
/proc/sys/vm/compact_memory.
If my guess is correct, an initialization are needed for that case.


Signed-off-by: Gioh Kim <gioh.kim@....com>
---
 mm/compaction.c |    8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/mm/compaction.c b/mm/compaction.c
index 8c0d945..944a9cc 100644
--- a/mm/compaction.c
+++ b/mm/compaction.c
@@ -1299,6 +1299,14 @@ static int compact_zone(struct zone *zone, struct compact_control *cc)
 		__reset_isolation_suitable(zone);
 
 	/*
+	 * If this is activated by /proc/sys/vm/compact_memory
+	 * and the first try, cached information for compaction is not
+	 * initialized.
+	 */
+	if (cc->order == -1 && zone->compact_cached_free_pfn == 0)
+		__reset_isolation_suitable(zone);
+
+	/*
 	 * Setup to move all movable pages to the end of the zone. Used cached
 	 * information on where the scanners should start but check that it
 	 * is initialised by ensuring the values are within zone boundaries.
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/