linux-kernel - Re: [PATCH v3 -tip] perf tools: fix building error for arm64.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2015 14:23:16 +0800
From:	Wang Nan <wangnan0@...wei.com>
To:	Ingo Molnar <mingo@...hat.com>, Ingo Molnar <mingo@...nel.org>
CC:	Namhyung Kim <namhyung@...nel.org>, <jolsa@...nel.org>,
	<acme@...nel.org>, <lizefan@...wei.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 -tip] perf tools: fix building error for arm64.

Hi Ingo,

Could you please pick this patch for -tip tree? It fixes a bug which makes
arm64 -tip building failure.

Thank you.

On 2015/3/18 15:19, Namhyung Kim wrote:
> On Tue, Mar 17, 2015 at 01:29:47PM +0000, Wang Nan wrote:
>> Commit b11db6581beaccef8ae9a388ae96074aa5cc144f ("perf tools: Fix build
>> error on ARCH=i386/x86_64/sparc64") uses sed on ARCH, which triggers a
>> bug in sequence of sed expression, where 's/arm.*/arm/' will replace
>> 'arm64' to 'arm', causes arm64 building failure.
>>
>> This patch prevent 'arm64' to be mached for 'arm.*' case.
>>
>> Signed-off-by: Wang Nan <wangnan0@...wei.com>
> 
> Acked-by: Namhyung Kim <namhyung@...nel.org>
> 
> Thanks,
> Namhyung
> 
> 
>> ---
>> v2 -> v3:
>>   Make the 'arm.*' expression complete according to Jiri Olsa's suggestion.
>> ---
>>  tools/perf/config/Makefile.arch | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/config/Makefile.arch b/tools/perf/config/Makefile.arch
>> index e972057..e11fbd6 100644
>> --- a/tools/perf/config/Makefile.arch
>> +++ b/tools/perf/config/Makefile.arch
>> @@ -4,7 +4,7 @@ endif
>>  
>>  ARCH := $(shell echo $(ARCH) | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
>>                                    -e s/sun4u/sparc/ -e s/sparc64/sparc/ \
>> -                                  -e s/arm.*/arm/ -e s/sa110/arm/ \
>> +                                  -e /arm64/!s/arm.*/arm/ -e s/sa110/arm/ \
>>                                    -e s/s390x/s390/ -e s/parisc64/parisc/ \
>>                                    -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
>>                                    -e s/sh[234].*/sh/ -e s/aarch64.*/arm64/ \
>> -- 
>> 1.8.3.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/