linux-kernel - Re: [PATCH] clocksource: atmel-st: select REGMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150319090216.634797ef@bbrezillon>
Date:	Thu, 19 Mar 2015 09:02:16 +0100
From:	Boris Brezillon <boris.brezillon@...e-electrons.com>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Daniel Lezcano <daniel.lezcano@...aro.org>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] clocksource: atmel-st: select REGMAP_MMIO

Hi Alexandre,

On Wed, 18 Mar 2015 12:06:35 +0100
Alexandre Belloni <alexandre.belloni@...e-electrons.com> wrote:

> Enforce REGMAP_MMIO selection as the driver needs it. Else, it will still
> compile with some warning about X1, x2 or sr being used uninitialized.
> 
> Reported-by: fengguang.wu@...el.com
> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> ---
> Daniel,
> 
> I think this should go through the at91 tree as the patch introducing that issue
> went there.
> 
>  drivers/clocksource/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 168035883afa..3cc97b217019 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -146,6 +146,7 @@ config ATMEL_PIT
>  config ATMEL_ST
>  	bool
>  	select CLKSRC_OF
> +	select REGMAP_MMIO

Shouldn't we select MFD_SYSCON instead.

Regards,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/