linux-kernel - Re: [PATCH v7] media: i2c: add support for omnivision's ov2659 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2015 09:39:53 +0000
From:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:	Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Rob Herring <robh+dt@...nel.org>,
	Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Hans Verkuil <hans.verkuil@...co.com>,
	LMML <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v7] media: i2c: add support for omnivision's ov2659 sensor

Hi Sakari,

Thanks for the review.

On Wed, Mar 18, 2015 at 10:13 PM, Sakari Ailus
<sakari.ailus@...ux.intel.com> wrote:
> Hi Prabhakar,
>
> Lad Prabhakar wrote:
> ...
>>
>> +static int ov2659_g_volatile_ctrl(struct v4l2_ctrl *ctrl)
>> +{
>> +       struct ov2659 *ov2659 =
>> +                       container_of(ctrl->handler, struct ov2659, ctrls);
>> +       struct v4l2_mbus_framefmt *fmt = &ov2659->format;
>> +
>> +       switch (ctrl->id) {
>> +       case V4L2_CID_PIXEL_RATE:
>> +               if (fmt->code != MEDIA_BUS_FMT_SBGGR8_1X8)
>> +                       ov2659->link_frequency->val =
>> +                                       ov2659->pdata->link_frequency / 2;
>> +               else
>> +                       ov2659->link_frequency->val =
>> +                                       ov2659->pdata->link_frequency;
>
>
> You should simply use v4l2_ctrl_s_ctrl_int64() in ..._set_fmt() as this
> isn't really a proper volatile control, but its value depends on the format.
>
Yea makes sense, will respin the patch with this change.

Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/