linux-kernel - Re: [PATCH v2] checkpatch: support more uppercase $logFunctions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJ7vePC2BrB1LaqbTcOq3132_q9Eg=LDH_zFaeNun1itTy7YxA@mail.gmail.com>
Date:	Thu, 19 Mar 2015 10:57:23 +0100
From:	Tom Van Braeckel <tomvanbraeckel@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Robo Bot <apw@...onical.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] checkpatch: support more uppercase $logFunctions

>> unfixable checkpatch warnings (an example: drivers/bluetooth/btusb.c)
>
> I think BT_DBG is a poor macro as it's just
>
> #define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__)
>
> and I'd rather see a treewide sed for that to pr_debug

Indeed, I also think that BT_DBG() is a poor macro and that it should
be fixed tree-wide. I might even do it myself, in a separate patch.

The reason for DBG being in the current patch is to match other *_DBG()
log functions that make more sense, such as NS_DBG().

As for the btusb.c example case, this patch allows us to fix the
"quoted string split across lines" warning caused by the BT_INFO()
macro. The fix will be to not to split the quoted string, which will
be allowed when BT_INFO() is recognized as a log function.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/