linux-kernel - Re: [PATCH] x86: remove unused get_bios_ebda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150319111643.GA11530@pd.tnic>
Date:	Thu, 19 Mar 2015 12:16:44 +0100
From:	Borislav Petkov <bp@...en8.de>
To:	Alexander Kuleshov <kuleshovmail@...il.com>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
	Mike Waychison <mikew@...gle.com>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH] x86: remove unused get_bios_ebda_length

On Thu, Mar 19, 2015 at 04:55:37PM +0600, Alexander Kuleshov wrote:
> get_bios_ebda_length function from <asm/bios_ebda.h> was added
> in the 57d5f9f808b7650a92f31e9cd3acd3f415a22530 commit, but

You probably should've added the people involved in that commit to CC.
They might still need it, although I doubt it. :-)

> still not uses anywhere, let's remove it.
> 
> Signed-off-by: Alexander Kuleshov <kuleshovmail@...il.com>
> ---
>  arch/x86/include/asm/bios_ebda.h | 21 ---------------------
>  1 file changed, 21 deletions(-)
> 
> diff --git a/arch/x86/include/asm/bios_ebda.h b/arch/x86/include/asm/bios_ebda.h
> index aa6a317..2b00c77 100644
> --- a/arch/x86/include/asm/bios_ebda.h
> +++ b/arch/x86/include/asm/bios_ebda.h
> @@ -17,27 +17,6 @@ static inline unsigned int get_bios_ebda(void)
>  	return address;	/* 0 means none */
>  }
>  
> -/*
> - * Return the sanitized length of the EBDA in bytes, if it exists.
> - */
> -static inline unsigned int get_bios_ebda_length(void)
> -{
> -	unsigned int address;
> -	unsigned int length;
> -
> -	address = get_bios_ebda();
> -	if (!address)
> -		return 0;
> -
> -	/* EBDA length is byte 0 of the EBDA (stored in KiB) */
> -	length = *(unsigned char *)phys_to_virt(address);
> -	length <<= 10;
> -
> -	/* Trim the length if it extends beyond 640KiB */
> -	length = min_t(unsigned int, (640 * 1024) - address, length);
> -	return length;
> -}
> -
>  void reserve_ebda_region(void);
>  
>  #ifdef CONFIG_X86_CHECK_BIOS_CORRUPTION
> -- 
> 2.3.3.472.g20ceeac.dirty
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/