linux-kernel - Re: [PATCHv2 01/12] usb: add bus type for USB ULPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150319114425.GA2435@kuha.fi.intel.com>
Date:	Thu, 19 Mar 2015 13:44:25 +0200
From:	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To:	Paul Bolle <pebolle@...cali.nl>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	David Cohen <david.a.cohen@...ux.intel.com>,
	Stephen Boyd <sboyd@...eaurora.org>,
	Baolu Lu <baolu.lu@...ux.intel.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCHv2 01/12] usb: add bus type for USB ULPI

> > +#include <linux/module.h>
> 
> So is this include needed?

I can change it to linux/kmod.h. We'll still do the request_module
call even after these changes.

> > +static int __init ulpi_init(void)
> > +{
> > +	return bus_register(&ulpi_bus);
> > +}
> > +module_init(ulpi_init);
> 
> This will be equivalent to
>     __initcall(ulpi_init)
> 
> according to include/linux/init.h.

I'll change it to subsys_initcall(ulpi_init).

> > +static void __exit ulpi_exit(void)
> > +{
> > +	bus_unregister(&ulpi_bus);
> > +}
> > +module_exit(ulpi_exit);
> 
> This will never be called.
> 
> > +MODULE_AUTHOR("Intel Corporation");
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("USB ULPI PHY bus");
> 
> And these three macros will be, effectively, preprocessed away.

True. I'll drop them.


Thanks,

-- 
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/