[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20150319013617.GG14051@verge.net.au>
Date: Thu, 19 Mar 2015 10:36:18 +0900
From: Simon Horman <horms@...ge.net.au>
To: Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Jason Cooper <jason@...edaemon.net>,
Magnus Damm <magnus.damm@...il.com>, linux-sh@...r.kernel.org,
devicetree@...r.kernel.org, linux-pm@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] irqchip: renesas-irqc: Add more register
documentation
On Wed, Mar 18, 2015 at 07:55:55PM +0100, Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
Reviewed-by: Simon Horman <horms+renesas@...ge.net.au>
> ---
> drivers/irqchip/irq-renesas-irqc.c | 20 +++++++++++++++-----
> 1 file changed, 15 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/irqchip/irq-renesas-irqc.c b/drivers/irqchip/irq-renesas-irqc.c
> index 2ea3412fdf8cc668..2ce2edf8ec8ec182 100644
> --- a/drivers/irqchip/irq-renesas-irqc.c
> +++ b/drivers/irqchip/irq-renesas-irqc.c
> @@ -30,14 +30,24 @@
> #include <linux/module.h>
> #include <linux/platform_data/irq-renesas-irqc.h>
>
> -#define IRQC_IRQ_MAX 32 /* maximum 32 interrupts per driver instance */
> +#define IRQC_IRQ_MAX 32 /* maximum 32 interrupts per driver instance */
>
> -#define IRQC_REQ_STS 0x00
> -#define IRQC_EN_STS 0x04
> -#define IRQC_EN_SET 0x08
> +#define IRQC_REQ_STS 0x00 /* Interrupt Request Status Register */
> +#define IRQC_EN_STS 0x04 /* Interrupt Enable Status Register */
> +#define IRQC_EN_SET 0x08 /* Interrupt Enable Set Register */
> #define IRQC_INT_CPU_BASE(n) (0x000 + ((n) * 0x10))
> -#define DETECT_STATUS 0x100
> + /* SYS-CPU vs. RT-CPU */
> +#define DETECT_STATUS 0x100 /* IRQn Detect Status Register */
> +#define MONITOR 0x104 /* IRQn Signal Level Monitor Register */
> +#define HLVL_STS 0x108 /* IRQn High Level Detect Status Register */
> +#define LLVL_STS 0x10c /* IRQn Low Level Detect Status Register */
> +#define S_R_EDGE_STS 0x110 /* IRQn Sync Rising Edge Detect Status Reg. */
> +#define S_F_EDGE_STS 0x114 /* IRQn Sync Falling Edge Detect Status Reg. */
> +#define A_R_EDGE_STS 0x118 /* IRQn Async Rising Edge Detect Status Reg. */
> +#define A_F_EDGE_STS 0x11c /* IRQn Async Falling Edge Detect Status Reg. */
> +#define CHTEN_STS 0x120 /* Chattering Reduction Status Register */
> #define IRQC_CONFIG(n) (0x180 + ((n) * 0x04))
> + /* IRQn Configuration Register */
>
> struct irqc_irq {
> int hw_irq;
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists