linux-kernel - Re: [PATCH 1/2] staging: sm750fb: remove 750LE code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150319141539.GD7046@kroah.com>
Date:	Thu, 19 Mar 2015 15:15:39 +0100
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	linux-fbdev@...r.kernel, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, dan.carpenter@...cle.com
Subject: Re: [PATCH 1/2] staging: sm750fb: remove 750LE code

On Thu, Mar 19, 2015 at 07:33:28PM +0530, Sudip Mukherjee wrote:
> On Thu, Mar 19, 2015 at 02:22:36PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Mar 19, 2015 at 06:47:40PM +0530, Sudip Mukherjee wrote:
> > > 750LE is a special version of the hardware with Ip Core and
> > > Silicon Motion is making this hardware only for Huawei. It is not
> > > available to anyone else.
> > 
> > And Huawei doesn't run Linux?  (hint, they do...)
> > 
> > Why remove this if someone can use it?  I don't understand.
> 
> this is part of my conversation with Teddy Wang of Silicon Motion:
> "I think you can remove it .  SM750LE is a special version. And it's
> just a IP core. No one except huawei will use it."
> 
> and moreover I donot have that 750LE hardware to test any changes.
> I just have the SM712 and SM750 hardware. so ....
> 
> now, whatever you decide .. I will surely like to have the code in
> place.

I suggest to leave it, it's not costing anything to keep around, and I
think you removed additional code with this patch anyway, which wasn't
good...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/