linux-kernel - Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load successfully early.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2015 11:29:57 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Borislav Petkov <bp@...en8.de>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Doug Thompson <dougthompson@...ssion.com>,
	linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@....samsung.com>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	Olof Johansson <olof@...om.net>,
	Arjan van de Ven <arjan@...ux.intel.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"Luis R . Rodriguez" <mcgrof@...e.com>
Subject: Re: [PATCH 3/3] EDAC: amd64_edac: decide if driver can load
 successfully early.

Hello, Borislav.

On Thu, Mar 19, 2015 at 10:40:54AM +0100, Borislav Petkov wrote:
> This is why I did the drv_instances hack - I don't want it to load if
> there's no ECC support on the system as it is confusing to people and
> tools.
> 
> It'd need to be able for the async probing to unload the driver if not a
> single node instance loads successfully.

I don't really think this is the type of things we want to be doing in
the specific drivers.  It makes the driver behave differnetly from
everything else.  If a feature like this is actually necessary, please
implement a proper abstraction at the driver layer (e.g. a flag to
indicate that if the initial probe fails, there's no point in keeping
the driver around) but frankly I don't think this matters enough to
warrant such extra complexities.

This is a gloss layering violation.  Please don't do things like this.
I'm all for ripping out the hack even w/o considering the async probe
issue.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/