linux-kernel - Re: [PATCH] tools: unbreak 'make tools/*'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2015 09:11:03 -0700
From:	Brian Norris <computersforpeace@...il.com>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Jiri Olsa <jolsa@...nel.org>, Michal Marek <mmarek@...e.cz>,
	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	David Howells <dhowells@...hat.com>,
	Borislav Petkov <bp@...e.de>, Sam Ravnborg <sam@...nborg.org>
Subject: Re: [PATCH] tools: unbreak 'make tools/*'

On Thu, Mar 19, 2015 at 03:20:26PM +0100, Jiri Olsa wrote:
> On Thu, Mar 19, 2015 at 10:39:25AM -0300, Arnaldo Carvalho de Melo wrote:
> 
> SNIP
> 
> > [acme@...andy linux]$
> > 
> > -------------------------------------------------------
> > 
> > Jiri, can you take a look at the above?
> > 
> > It works if I use 'make -C', with O=, like I usually do, or without it:
> > 
> > -------------------------------------------------------
> > 
> > [acme@...andy linux]$ make -C tools/perf
> > make: Entering directory `/home/acme/git/linux/tools/perf'
> >   BUILD:   Doing 'make -j8' parallel build
> > 
> > Auto-detecting system features:
> > ...                         dwarf: [ on  ]
> > ...                         glibc: [ on  ]
> > <SNIP>
> > ...                     libunwind: [ OFF ]
> > ...            libdw-dwarf-unwind: [ on  ]
> > ...                          zlib: [ on  ]
> > 
> > config/Makefile:308: No libunwind found. Please install libunwind-dev[el] >= 1.1 and/or set LIBUNWIND_DIR
> > config/Makefile:598: No libbabeltrace found, disables 'perf data' CTF format support, please install libbabeltrace-dev[el]/libbabeltrace-ctf-dev
> >   GEN      common-cmds.h
> >   CC       util/abspath.o
> >   CC       ui/setup.o
> >   CC       arch/common.o
> > 
> > 
> > -------------------------------------------------------
> > 
> > Can you please check these issues, using my perf/core branch at:
> 
> hum, I've never cared about tools/Makefile :-\
> 
> so this is what we want to be able to do/use? :
> 
>   $ make tools/
>   $ make tools/perf
>   $ make O=$(BUILDDIR) tools/perf

Honestly, I only was caring about 'make tools/tmon' but noticed other
things were broken. I'd be OK if we didn't support building from the
top-level directory (it's just confusing things here), but since we
advertise the feature, it'd really better work!

> it ^^^ does not work for me even with this patch
> (tools/Makefile still using 'libapikfs' being first issue I saw)
> 
> I'll check and send fix

Yeah, I'm not likely to spend time on an updated fix real soon. Consider
my patch a bug report, if the suggested fix doesn't work out. I'm not
much of a build system expert here.

Thanks,
Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/