linux-kernel - [PATCH] crypto: img-hash: Fix Kconfig selections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2015 16:46:24 +0000
From:	James Hartley <james.hartley@...tec.com>
To:	Valentin Rothberg <valentinrothberg@...il.com>,
	<abrestic@...omium.org>, <herbert@...dor.apana.org.au>,
	<davem@...emloft.net>, <linux-kernel@...r.kernel.org>,
	<linux-crypto@...r.kernel.org>
CC:	Paul Bolle <pebolle@...cali.nl>,
	Andreas Ruprecht <rupran@...server.de>,
	hengelein Stefan <stefan.hengelein@....de>,
	<james.hartley@...tec.com>
Subject: [PATCH] crypto: img-hash: Fix Kconfig selections

The Kconfig entry for CRYPTO_DEV_IMGTEC_HASH incorrectly selects
CRYPTO_SHA224, which does not exist (and is covered by CRYPTO_SHA256
which covers both 224 and 256). Remove it.

Also correct typo CRYPTO_ALG_API to be CRYPTO_ALGPI.

Reported-by: Valentin Rothberg <valentinrothberg@...il.com>
Signed-off-by: James Hartley <james.hartley@...tec.com>
---
 drivers/crypto/Kconfig |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 8b18b66..800bf41 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -448,10 +448,9 @@ source "drivers/crypto/vmx/Kconfig"
 config CRYPTO_DEV_IMGTEC_HASH
 	depends on MIPS || COMPILE_TEST
 	tristate "Imagination Technologies hardware hash accelerator"
-	select CRYPTO_ALG_API
+	select CRYPTO_ALGAPI
 	select CRYPTO_MD5
 	select CRYPTO_SHA1
-	select CRYPTO_SHA224
 	select CRYPTO_SHA256
 	select CRYPTO_HASH
 	help
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/