linux-kernel - RE: [PATCH] x86, mce, severities: Add AMD severities function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Mar 2015 17:15:36 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>,
	Borislav Petkov <bp@...en8.de>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"slaoub@...il.com" <slaoub@...il.com>,
	"luto@...capital.net" <luto@...capital.net>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: RE: [PATCH] x86, mce, severities: Add AMD severities function

>> It would be best if what Tony suggested comes ontop of your patch with
>> his Suggested-by: tag. This ordering should be also the easiest wrt
>> functionality and bisectability.
>>
>>
>
> Ok, I'll have it ready and send out a V2 by tomorrow if there are no 
> other comments/reviews.

Fame & glory ... whatever. Just be sure to make the _intel() and _amd()
severity functions "static" ... so you'll need something like this in mce-severity.c

void mce_vendor_severity_init(void)
{
	.... assign mce_severity here
}

-Tony