linux-kernel - Re: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions for PMU driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150319175409.GE10153@leverpostej>
Date:	Thu, 19 Mar 2015 17:54:09 +0000
From:	Mark Rutland <mark.rutland@....com>
To:	"Suzuki K. Poulose" <Suzuki.Poulose@....com>
Cc:	Sudeep Holla <Sudeep.Holla@....com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Nicolas Pitre <nico@...aro.org>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Kukjin Kim <kgene@...nel.org>,
	Abhilash Kesavan <a.kesavan@...sung.com>,
	Arnd Bergmann <arnd@...db.de>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Liviu Dudau <Liviu.Dudau@....com>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	Olof Johansson <olof@...om.net>,
	Pawel Moll <Pawel.Moll@....com>,
	Punit Agrawal <Punit.Agrawal@....com>,
	Will Deacon <Will.Deacon@....com>,
	Catalin Marinas <Catalin.Marinas@....com>
Subject: Re: [UPDATED] [PATCH 3/5] arm-cci: Get rid of secure transactions
 for PMU driver

On Thu, Mar 19, 2015 at 05:52:54PM +0000, Suzuki K. Poulose wrote:
> On 19/03/15 17:38, Sudeep Holla wrote:
> >
> >
> > On 19/03/15 17:32, Mark Rutland wrote:
> >> One more thing:
> >>
> >>> @@ -883,7 +894,11 @@ static inline const struct cci_pmu_model *get_cci_model(struct platform_device *
> >>>    							pdev->dev.of_node);
> >>>    	if (!match)
> >>>    		return NULL;
> >>> +	if (match->data)
> >>> +		return match->data;
> >>>
> >>> +	dev_warn(&pdev->dev, "DEPRECATED compatible property,"
> >>> +			 "requires secure access to CCI registers");
> >>>    	return probe_cci_model(pdev);
> >>>    }
> >>
> >> Before the probe, could we please have:
> >>
> >> 	if (!IS_ENABLED(CONFIG_ARM))
> >> 		return -EINVAL;
> >>
> >> On arm64 we require a model-specific string, and we shouldn't go
> >> touching secure-only registers.
> >>
> >
> > IIUC platform_has_secure_cci_access always return false for ARM64
> > preventing any secure access. No ?
> >
> Yes, you are right. The check has been abstracted away with the 
> platform_has_secure_cci_access().

Ah, that's fine then.

Sorry for the noise!

Mark.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/