linux-kernel - Re: [PATCH 28/32] tile: copy_thread(): rename 'arg' argument to 'kthread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550B103B.801@ezchip.com>
Date:	Thu, 19 Mar 2015 14:06:51 -0400
From:	Chris Metcalf <cmetcalf@...hip.com>
To:	Alex Dowad <alexinbeijing@...il.com>,
	<linux-kernel@...r.kernel.org>
CC:	Christoph Lameter <cl@...ux.com>, Joe Perches <joe@...ches.com>,
	Tejun Heo <tj@...nel.org>, james hogan <james.hogan@...tec.com>
Subject: Re: [PATCH 28/32] tile: copy_thread(): rename 'arg' argument to 'kthread_arg'

On 03/16/2015 04:44 PM, Alex Dowad wrote:
>
> On 16/03/15 22:19, Chris Metcalf wrote:
>> On 3/13/2015 2:14 PM, Alex Dowad wrote:
>>> The 'arg' argument to copy_thread() is only ever used when forking a 
>>> new
>>> kernel thread. Hence, rename it to 'kthread_arg' for clarity (and 
>>> consistency
>>> with do_fork() and other arch-specific implementations of 
>>> copy_thread()).
>>>
>>> Signed-off-by: Alex Dowad<alexinbeijing@...il.com>
>>> ---
>>>   arch/tile/kernel/process.c | 11 +++++++----
>>>   1 file changed, 7 insertions(+), 4 deletions(-)
>>
>> Acked-by: Chris Metcalf <cmetcalf@...hip.com>
>>
>> If you would prefer me to take this into the tile tree, let me know, 
>> and I am happy to do so.
>>
> Hi Chris,
>
> Thanks for your kind offer. I am a 100% genuine true-blue kernel 
> newbie and have no idea whether a change like this should be merged 
> individually by each arch maintainer, or all together at some point 
> upstream (or is it downstream? I'm not sure about my streams). Do you 
> have any suggestion?
>
> Thank you again! AD

I think James Hogan's replies were on-target [1].  My sense is that 
since it's a cleanup, and since you're trying for consistency, if you 
can gather up a few Acked-by's from maintainers, it probably makes sense 
to have it taken as a series.

[1] https://lkml.org/lkml/2015/3/16/477

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/