linux-kernel - Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20150319152305.d4ff5c83744591ff9340db92@linux-foundation.org>
Date:	Thu, 19 Mar 2015 15:23:05 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	mfasheh@...e.com, jlbec@...lplan.org, ocfs2-devel@....oracle.com,
	linux-kernel@...r.kernel.org, richard.weinberger@...il.com
Subject: Re: [PATCH 1/4 V2] ocfs2: use retval instead of status for checking
 error

On Sat, 28 Feb 2015 08:48:40 +0900 Daeseok Youn <daeseok.youn@...il.com> wrote:

> The use of 'status' in __ocfs2_add_entry() can return wrong
> status when some functions are failed.
> 
> If ocfs2_journal_access_db() in __ocfs2_add_entry() is failed,
> that status is saved to 'status' but return variable is 'retval'
> which is saved 'success' status. In case of this,  __ocfs2_add_entry()
> is failed but can be returned as 'success'.
> 
> So replace 'status' with 'retval'.
> 
> -						mlog_errno(status);
> +					if (retval) {
> +						mlog_errno(retval);
>  						goto bail;

and

bail:
	if (retval)
		mlog_errno(retval);

	return retval;
}

so we'll clearly log the same error twice.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/