linux-kernel - Re: [PATCH -next] mm: MEMTEST depends on MEMBLOCK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426847014.23529.35.camel@x220>
Date:	Fri, 20 Mar 2015 11:23:34 +0100
From:	Paul Bolle <pebolle@...cali.nl>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	valentinrothberg@...il.com, rupran@...server.de,
	stefan.hengelein@....de, Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Vladimir Murzin <vladimir.murzin@....com>
Subject: Re: [PATCH -next] mm: MEMTEST depends on MEMBLOCK

On Fri, 2015-03-13 at 02:03 -0700, Guenter Roeck wrote:
> Building alpha:allmodconfig fails with
> 
> mm/memtest.c: In function 'reserve_bad_mem':
> mm/memtest.c:38:2: error: implicit declaration of function 'memblock_reserve'
> mm/memtest.c: In function 'do_one_pass':
> mm/memtest.c:77:2: error: implicit declaration of function 'for_each_free_mem_range'
> mm/memtest.c:77:73: error: expected ';' before '{' token
> 
> because it depends on MEMBLOCK which is not defined for the alpha
> architecture.
> 
> Fixes: 420c89e6185d ("mm: move memtest under mm")
> Cc: Vladimir Murzin <vladimir.murzin@....com>
> Signed-off-by: Guenter Roeck <linux@...ck-us.net>
> ---
>  lib/Kconfig.debug | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 8b4e69a..dc1e69c 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1797,6 +1797,7 @@ config TEST_UDELAY
>  
>  config MEMTEST
>  	bool "Memtest"
> +	depends on MEMBLOCK
>  	---help---
>  	  This option adds a kernel parameter 'memtest', which allows memtest
>  	  to be set.

(There's now a bot checking this stuff, but I couldn't resist reporting
it when my script spotted it.)

Please do
    $ git grep -n "config\s\+MEMBLOCK\b" next-20150320
    $ git grep -n "config\s\+MEMBLOCK\b" v4.0-rc4

I think this patch simply disables MEMTEST altogether. I'm guessing this
should have added
	depends on HAVE_MEMBLOCK


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/