linux-kernel - Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8uMa9j5BHKPDakXYZn_cXwp_e8t1CyguVshJTm=A-mqMQ@mail.gmail.com>
Date:	Fri, 20 Mar 2015 12:10:51 +0000
From:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:	Varka Bhadram <varkabhadram@...il.com>
Cc:	LMML <linux-media@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v8] media: i2c: add support for omnivision's ov2659 sensor

On Fri, Mar 20, 2015 at 12:05 PM, Varka Bhadram <varkabhadram@...il.com> wrote:
> On 03/20/2015 05:18 PM, Lad Prabhakar wrote:
>
>> From: Benoit Parrot <bparrot@...com>
>>
>> this patch adds support for omnivision's ov2659
>> sensor, the driver supports following features:
>> 1: Asynchronous probing
>> 2: DT support
>> 3: Media controller support
>>
>> Signed-off-by: Benoit Parrot <bparrot@...com>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
>> Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>
>> ---
>>   Changes for v8:
>>   --------------
>>   a. Now setting the link_frequency control in set_fmt
>>      callback instead of implementing g_volatile_ctrl()
>>      for it and setting it there.
>>
>>   v7: https://patchwork.kernel.org/patch/6034651/
>>   v6: https://patchwork.kernel.org/patch/6012751/
>>   v5: https://patchwork.kernel.org/patch/6000161/
>>   v4: https://patchwork.kernel.org/patch/5961661/
>>   v3: https://patchwork.kernel.org/patch/5959401/
>>   v2: https://patchwork.kernel.org/patch/5859801/
>>   v1: https://patchwork.linuxtv.org/patch/27919/
>>
>>   .../devicetree/bindings/media/i2c/ov2659.txt       |   38 +
>>   MAINTAINERS                                        |   10 +
>>   drivers/media/i2c/Kconfig                          |   11 +
>>   drivers/media/i2c/Makefile                         |    1 +
>>   drivers/media/i2c/ov2659.c                         | 1528
>> ++++++++++++++++++++
>>   include/media/ov2659.h                             |   33 +
>>   6 files changed, 1621 insertions(+)
>>   create mode 100644
>> Documentation/devicetree/bindings/media/i2c/ov2659.txt
>>   create mode 100644 drivers/media/i2c/ov2659.c
>>   create mode 100644 include/media/ov2659.h
>>
> (...)
>
>> +static struct ov2659_platform_data *
>> +ov2659_get_pdata(struct i2c_client *client)
>> +{
>> +       struct ov2659_platform_data *pdata;
>> +       struct device_node *endpoint;
>> +       int ret;
>> +
>> +       if (!IS_ENABLED(CONFIG_OF) || !client->dev.of_node) {
>> +               dev_err(&client->dev, "ov2659_get_pdata: DT Node
>> found\n");
>
>
> ov2659_get_pdata: DT Node *not* found...?
>
Good catch!

Cheers,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/