linux-kernel - Re: [PATCH 1/1] Add mkopci driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvyqbzjE0yU=KmH+fci2eokqPVixfiU7mpFQApcM7LrU8w@mail.gmail.com>
Date:	Fri, 20 Mar 2015 13:43:50 +0100
From:	Richard Weinberger <richard.weinberger@...il.com>
To:	sergej.bauer@...il.com
Cc:	LKML <linux-kernel@...r.kernel.org>, Arnd Bergmann <arnd@...db.de>,
	Greg KH <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/1] Add mkopci driver

Sergej,

On Fri, Mar 20, 2015 at 1:10 PM,  <sergej.bauer@...il.com> wrote:
> mkopci (MB11.xx) device (RC Module project) provides data transference through a serial bus bar according to MIL-STD-1553.
> the driver used for operating devices, reads PCI configuration space and pass interrupts to user-space applications.
>
> Please consider adding this patch to the linux-next queue.

>From a quick look I'd suggest to get the driver first in shape.

- You add new proc files, which is not really welcomed. Please consider sysfs.
- In the debug prints you compare against current->comm, also not nice.
- You use printk() in the interrupt handler.
- Why is this a misc driver at all? Does it really not fit into any
other device class?
- I'm sure running checkpatch.pl against the patch would also not hurt. :)

-- 
Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/