linux-kernel - d_path() and overlay fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150320132914.GA1749@ws.net.home>
Date:	Fri, 20 Mar 2015 14:29:14 +0100
From:	Karel Zak <kzak@...hat.com>
To:	Alexander Viro <viro@...iv.linux.org.uk>,
	Miklos Szeredi <miklos@...redi.hu>
Cc:	linux-kernel@...r.kernel.org
Subject: d_path() and overlay fs


 Hi,

 kernel-4.0.0-0.rc4.git1.3.fc23 (I have nothing more recent right now,
 sorry it the problem is already fixed).
 
 It seems like d_path() kernel function returns nonsenses for overlay fs.

 Example:

   # mount -t overlay overlay -olowerdir=/mnt/low,upperdir=/mnt/up/data,workdir=/mnt/up/work /mnt/merged
   # dd if=/dev/zero of=/mnt/merged/image count=1 bs=1MiB

   # losetup -f /mnt/merged/image

   # cat /sys/block/loop0/loop/backing_file 
   /image


 ...should be /mnt/merged/image.

 drivers/block/loop.c: loop_attr_backing_file_show() uses d_path()

 It seems like serious problem because kernel uses d_path() (and
 friends) on many places to generate path strings for userspace in
 /proc and /sys and people already use overlay fs in containers.
 
 Another example:
 
   # cat /proc/swaps 
   Filename               Type        Size    Used    Priority
   /dev/sda6              partition   8191996 258308  -1
   /image                 file        1020    0       -2


    Karel

-- 
 Karel Zak  <kzak@...hat.com>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/