linux-kernel - Re: [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550C2931.3010702@linaro.org>
Date:	Fri, 20 Mar 2015 15:05:37 +0100
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Richard Weinberger <richard@....at>, linux-kernel@...r.kernel.org
CC:	linux-iio@...r.kernel.org, linux-pm@...r.kernel.org,
	dwmw2@...radead.org, dbaryshkov@...il.com, sre@...nel.org,
	jassisinghbrar@...il.com, pmeerw@...erw.net, lars@...afoo.de,
	knaack.h@....de, jic23@...nel.org, tglx@...utronix.de
Subject: Re: [PATCH 1/6] clocksource/sh_cmt.c: Fix !HAS_IOMEM build

On 03/16/2015 10:27 PM, Richard Weinberger wrote:
> Fixes:
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_map_memory’:
> drivers/clocksource/sh_cmt.c:920:2: error: implicit declaration of function ‘ioremap_nocache’ [-Werror=implicit-function-declaration]
>    cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>    ^
> drivers/clocksource/sh_cmt.c:920:15: warning: assignment makes pointer from integer without a cast [enabled by default]
>    cmt->mapbase = ioremap_nocache(mem->start, resource_size(mem));
>                 ^
> drivers/clocksource/sh_cmt.c: In function ‘sh_cmt_setup’:
> drivers/clocksource/sh_cmt.c:1034:2: error: implicit declaration of function ‘iounmap’ [-Werror=implicit-function-declaration]
>    iounmap(cmt->mapbase);
>
> Signed-off-by: Richard Weinberger <richard@....at>
> ---

Applied to my tree for v4.0 fix.

Thanks !


>   drivers/clocksource/Kconfig | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
> index 68161f7..c948f4e 100644
> --- a/drivers/clocksource/Kconfig
> +++ b/drivers/clocksource/Kconfig
> @@ -192,6 +192,7 @@ config SYS_SUPPORTS_EM_STI
>   config SH_TIMER_CMT
>   	bool "Renesas CMT timer driver" if COMPILE_TEST
>   	depends on GENERIC_CLOCKEVENTS
> +	depends on HAS_IOMEM
>   	default SYS_SUPPORTS_SH_CMT
>   	help
>   	  This enables build of a clocksource and clockevent driver for
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/