linux-kernel - Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Mar 2015 13:48:43 +0100
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Ameen Ali <ameenali023@...il.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false
 because 'else if' condition matches previous condition at line 404.

On Wed, Feb 25, 2015 at 06:34:18PM +0200, Ameen Ali wrote:
> else if at line 406 has the same condition as the else if at line 404.
> i chosed 0x5 because it's half 0xb  (just a rate controller)
> Signed-off-by : Ameen Ali <Ameenali023@...il.com>
> ---
>  drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

How do you know this is correct?

Also, we need a blank line before the signed-off-by line and your
subject should give us a chance to know what driver is being changed, as
well as the subsystem.

Also, where are patches 1/3 and 2/3?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/