linux-kernel - Re: [PATCH] perf annotate: Fix the segmentation fault bug of perf annotate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150320154835.GK16485@kernel.org>
Date:	Fri, 20 Mar 2015 12:48:35 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Yunlong Song <yunlong.song@...wei.com>
Cc:	a.p.zijlstra@...llo.nl, paulus@...ba.org,
	Ingo Molnar <mingo@...nel.org>, linux-kernel@...r.kernel.org,
	wangnan0@...wei.com
Subject: Re: [PATCH] perf annotate: Fix the segmentation fault bug of perf
 annotate

Em Fri, Mar 20, 2015 at 09:52:14PM +0800, Yunlong Song escreveu:
> There is a segmentation fault bug in 'perf annotate' using the perf.data
> created by 'perf record -g', so fix it.

<SNIP>

> +++ b/tools/perf/util/annotate.c
> @@ -30,6 +30,9 @@ static int disasm_line__parse(char *line, char **namep, char **rawp);
>  
>  static void ins__delete(struct ins_operands *ops)
>  {
> +	if (ops == NULL)
> +		return;
> +

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/tools/perf/util/annotate.c#n31

https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/tools/perf?id=3995614d9b0320e10ce202836c8477e1bcf1a2d4

I.e. already upstream, it just needs to be merged with perf/core, either
Ingo or myself will do that soon,

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/