linux-kernel - Re: [PATCH v2] spi: Ensure that CS line is in non-active state after spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1426868089.14974.12.camel@mm-sol.com>
Date:	Fri, 20 Mar 2015 18:14:49 +0200
From:	"Ivan T. Ivanov" <iivanov@...sol.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v2] spi: Ensure that CS line is in non-active state
 after spi_setup()


On Fri, 2015-03-13 at 18:43 +0200, Ivan T. Ivanov wrote:
> Some devices samples state of the chip select signal during power up
> and act differently based on this state, so SPI core should ensure
> that CS line is driven in non-active state after spi_setup().
> 
> Signed-off-by: Ivan T. Ivanov <iivanov@...sol.com>
> ---

Any comments on this one?

Forget to add changes since v1 [1].

CS is set to non-active state unconditionally before
spi->master->setup()

Regards,
Ivan

[1] http://www.spinics.net/lists/linux-spi/msg03056.html

>  drivers/spi/spi.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c
> index c64a3e5..4023cc9 100644
> --- a/drivers/spi/spi.c
> +++ b/drivers/spi/spi.c
> @@ -1893,6 +1893,8 @@ int spi_setup(struct spi_device *spi)
>         if (!spi->max_speed_hz)
>                 spi->max_speed_hz = spi->master->max_speed_hz;
> 
> +       spi_set_cs(spi, false);
> +
>         if (spi->master->setup)
>                 status = spi->master->setup(spi);
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/