linux-kernel - RE: [PATCH] x86, mce, severities: Add AMD severities function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F32A25A94@ORSMSX114.amr.corp.intel.com>
Date:	Fri, 20 Mar 2015 17:49:57 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Borislav Petkov <bp@...en8.de>,
	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
CC:	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>,
	"slaoub@...il.com" <slaoub@...il.com>,
	"luto@...capital.net" <luto@...capital.net>,
	"x86@...nel.org" <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: RE: [PATCH] x86, mce, severities: Add AMD severities function

>> And I call this from mcheck_init().
>> I tested the above bits on AMD and the severities grading works fine.
>> 
>> Should we also come up with a '_default' function to assign to mce_severity
>> function pointer?
>
>I think that should be
>
>	default:
>		WARN_ONCE("WTF?!");
>		break;

mcheck_init() is called unconditionally from setup_arch().  So if anyone is
still using a Cyrix, Transmeta or other non-Intel, non-Amd processor we'd trip this WARN_ON.

I think you can have a default severity function that just does:

	return MCE_PANIC_SEVERITY;

just to avoid the unpleasant thought that we might jump through a NULL pointer
if we did somehow end up in do_machine_check() on another vendors cpu.

-Tony