linux-kernel - Re: [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Mar 2015 18:27:37 +0000
From:	Javi Merino <javi.merino@....com>
To:	Emil Velikov <emil.l.velikov@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"intel-gfx@...ts.freedesktop.org" <intel-gfx@...ts.freedesktop.org>,
	"Linux-Kernel@...r. Kernel. Org" <linux-kernel@...r.kernel.org>,
	ML dri-devel <dri-devel@...ts.freedesktop.org>,
	Daniel Vetter <daniel.vetter@...el.com>,
	Guenter Roeck <linux@...ck-us.net>,
	"Darrick J. Wong" <djwong@...ibm.com>
Subject: Re: [PATCH 1/4] kernel.h: Implement DIV_ROUND_CLOSEST_ULL

On Fri, Mar 20, 2015 at 06:19:26PM +0000, Emil Velikov wrote:
> On 20 March 2015 at 11:14, Javi Merino <javi.merino@....com> wrote:
> > We have grown a number of different implementations of
> > DIV_ROUND_CLOSEST_ULL throughout the kernel.  Move the i915 one to
> > kernel.h so that it can be reused.
> >
> > Cc: Daniel Vetter <daniel.vetter@...el.com>
> > Cc: Jani Nikula <jani.nikula@...ux.intel.com>
> > Cc: David Airlie <airlied@...ux.ie>
> > Cc: Darrick J. Wong <djwong@...ibm.com>
> > Cc: Guenter Roeck <linux@...ck-us.net>
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Signed-off-by: Javi Merino <javi.merino@....com>
> > ---
> >  drivers/gpu/drm/i915/intel_drv.h |  4 +---
> >  include/linux/kernel.h           | 11 +++++++++++
> >  2 files changed, 12 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
> > index eef79ccd0b7c..346e28fdd7dd 100644
> > --- a/drivers/gpu/drm/i915/intel_drv.h
> > +++ b/drivers/gpu/drm/i915/intel_drv.h
> > @@ -28,6 +28,7 @@
> >  #include <linux/async.h>
> >  #include <linux/i2c.h>
> >  #include <linux/hdmi.h>
> > +#include <linux/kernel.h>
> Hi Javi,
> 
> Small suggestion - can we include the header only where needed ?
> i915/intel_panel.c seems to be the only user of DIV_ROUND_CLOSEST
> which will need an update.
> 
> Somewhat trivial pick but it will prevent ~40 unnecessary dives in kernel.h.

Sure, I'll fix it in the next version of the series.

Cheers,
Javi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/