linux-kernel - Re: [PATCH v7 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150320204912.GC31953@sonymobile.com>
Date:	Fri, 20 Mar 2015 13:49:12 -0700
From:	Bjorn Andersson <bjorn.andersson@...ymobile.com>
To:	Andy Gross <agross@...eaurora.org>
CC:	Rob Herring <robh+dt@...nel.org>, Pawel Moll <pawel.moll@....com>,
	Mark Rutland <mark.rutland@....com>,
	Ian Campbell <ijc+devicetree@...lion.org.uk>,
	Ohad Ben-Cohen <ohad@...ery.com>,
	Kumar Gala <galak@...eaurora.org>, Suman Anna <s-anna@...com>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	Jeffrey Hugo <jhugo@...eaurora.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v7 1/2] DT: hwspinlock: Add binding documentation for
 Qualcomm hwmutex

On Fri 20 Mar 13:29 PDT 2015, Andy Gross wrote:

> On Thu, Mar 19, 2015 at 06:48:10PM -0700, Bjorn Andersson wrote:
> 
> <snip>
> 
> > +Example:
> > +
> > +	tcsr: syscon@...00000 {
> 
> typo here, syscon@...84000.  And this syscon is specifically for the tcsr mutex
> reg area.
> 

You're right, I didn't read the documentation good enough; let's name it
tcsr-mutex and as this is not the main tcsr region we should fall back
to just having syscon as compatible.

But there's still a bunch of other registers in the tcsr-mutex range -
that probably will be consumed by various drivers, so it still makes
sense to have a syscon there.

Sorry about the address, will update that as well.

> > +		compatible = "qcom,tcsr-msm8974", "syscon";
> > +		reg = <0xfd484000 0x2000>;
> 

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/