linux-kernel - Re: [PATCH 1/1] fs/affs/file.c: unlock/release page on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1105477909.130809.1426885981468.open-xchange@webmail.nmp.proximus.be>
Date:	Fri, 20 Mar 2015 22:13:01 +0100 (CET)
From:	Fabian Frederick <fabf@...net.be>
To:	akpm@...ux-foundation.org, Taesoo Kim <tsgatesv@...il.com>,
	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	jack@...e.cz, geert@...ux-m68k.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH 1/1] fs/affs/file.c: unlock/release page on error



> On 20 March 2015 at 04:19 Taesoo Kim <tsgatesv@...il.com> wrote:
>
>
> When affs_bread_ino() fails, correctly unlock the page and
> release the page cache with proper error value. All write_end()
> should unlock/release the page that was locked by write_beg().
>
> Signed-off-by: Taesoo Kim <tsgatesv@...il.com>
> ---
>  fs/affs/file.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/fs/affs/file.c b/fs/affs/file.c
> index d2468bf..15d07a0 100644
> --- a/fs/affs/file.c
> +++ b/fs/affs/file.c
> @@ -699,8 +699,10 @@ static int affs_write_end_ofs(struct file *file, struct
> address_space *mapping,
>       boff = tmp % bsize;
>       if (boff) {
>               bh = affs_bread_ino(inode, bidx, 0);
> -             if (IS_ERR(bh))
> -                     return PTR_ERR(bh);
> +             if (IS_ERR(bh)) {
> +                     written = PTR_ERR(bh);
> +                     goto err;
> +             }
>               tmp = min(bsize - boff, to - from);
>               BUG_ON(boff + tmp > bsize || tmp > bsize);
>               memcpy(AFFS_DATA(bh) + boff, data + from, tmp);
> @@ -712,8 +714,10 @@ static int affs_write_end_ofs(struct file *file, struct
> address_space *mapping,
>               bidx++;
>       } else if (bidx) {
>               bh = affs_bread_ino(inode, bidx - 1, 0);
> -             if (IS_ERR(bh))
> -                     return PTR_ERR(bh);
> +             if (IS_ERR(bh)) {
> +                     written = PTR_ERR(bh);
> +                     goto err;
> +             }
>       }
>       while (from + bsize <= to) {
>               prev_bh = bh;
> @@ -790,6 +794,7 @@ done:
>       if (tmp > inode->i_size)
>               inode->i_size = AFFS_I(inode)->mmu_private = tmp;
> 
> +err:
>       unlock_page(page);
>       page_cache_release(page);
> 
> --
> 2.3.3
>
Patch looks good. Maybe you could use more explicit labels like

err_first_bh instead of err
err_bh instead of out

Regards,
Fabian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/