linux-kernel - Re: [PATCH v8 tip 3/9] tracing: attach BPF programs to kprobes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550C9360.7060207@plumgrid.com>
Date:	Fri, 20 Mar 2015 14:38:40 -0700
From:	Alexei Starovoitov <ast@...mgrid.com>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	Ingo Molnar <mingo@...nel.org>, Namhyung Kim <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Jiri Olsa <jolsa@...hat.com>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	"David S. Miller" <davem@...emloft.net>,
	Daniel Borkmann <daniel@...earbox.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	linux-api@...r.kernel.org, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v8 tip 3/9] tracing: attach BPF programs to kprobes

On 3/20/15 2:09 PM, Steven Rostedt wrote:
>
>> +/**
>> + * trace_call_bpf - invoke BPF program
>> + * @prog - BPF program
>> + * @ctx - opaque context pointer
>> + *
>> + * kprobe handlers execute BPF programs via this helper.
>> + * Can be used from static tracepoints in the future.
>
> Should also state what the expected return values are. What does a
> return of "1" mean?

In earlier versions of this set I had detailed description of return
values from bpf program, somehow it got lost after all the revisions.
Will re-add.


> You are no longer in the net/ world. The rest of the Linux coding style
> is:
>
> 	/*
> 	 * multi line comments
> 	 */
>
> Only DaveM gets away with that format ;-)

:)
since bpf was born in the net/ world all comments are in that style.
When it moved into kernel/bpf/ we've decided to keep net/ style in there
as well, but for this file I don't mind using !net style ;)

> Reviewed-by: Steven Rostedt <rostedt@...dmis.org>

Thanks a lot. Will respin.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/