linux-kernel - Re: [PATCH] ARM: add PCI hotplug support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150320232223.GP26935@google.com>
Date:	Fri, 20 Mar 2015 18:22:23 -0500
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Ben Dooks <ben.dooks@...ethink.co.uk>
Cc:	linux@....linux.org.uk, linux-kernel@...ethink.co.uk,
	Linux ARM Kernel list <linux-arm-kernel@...ts.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux PCI List <linux-pci@...r.kernel.org>
Subject: Re: [PATCH] ARM: add PCI hotplug support

On Tue, Mar 17, 2015 at 12:22:32PM +0000, Ben Dooks wrote:
> Hotplug on PCIe should work with ARM, however the necessary
> PCIe hotplug is not availale as the menu items for PCI hotplug

"available"

> have not been included.
> 
> Add the include of PCI hotplug support to the ARM main Kconfig
> so that it can be selected.
> 
> The only issue that was found during this is that the PCI code
> did not assign interrupts properly to newly probed devices. This
> will need to be fixed for any interrupt capable devices.

Yep, this is a known PCI problem, at least if you're referring to
the fact that pci_fixup_irqs() only happens for devices present at
boot-time.  I would love for somebody to fix that generically.

I would also like to squash together the PCI, PCIe, and PCI hotplug Kconfig
options so arches would only have to include drivers/pci/Kconfig.

> This has been tested on a Marvell 88F6281 with a TI XIO3130
> PCIe bridge (with hotplug enabled) and fixes for IRQ assignment
> added.
> 
> Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>

I assume this will be handled via an ARM tree, but if you want it:

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

> --
> CC: Linux ARM Kernel list <linux-arm-kernel@...ts.infradead.org>
> CC: Russell King <linux@....linux.org.uk>
> CC: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
> CC: Bjorn Helgaas <bhelgaas@...gle.com>
> CC: Linux PCI List <linux-pci@...r.kernel.org>
> ---
>  arch/arm/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 9f1f09a..4574ab4 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -1302,6 +1302,7 @@ config PCI_HOST_ITE8152
>  	select DMABOUNCE
>  
>  source "drivers/pci/Kconfig"
> +source "drivers/pci/hotplug/Kconfig"
>  source "drivers/pci/pcie/Kconfig"
>  
>  source "drivers/pcmcia/Kconfig"
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/