linux-kernel - Re: [PATCH 33/35 linux-next] mmc: constify of_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1374583183.180918.1426968545752.open-xchange@webmail.nmp.proximus.be>
Date:	Sat, 21 Mar 2015 21:09:05 +0100 (CET)
From:	Fabian Frederick <fabf@...net.be>
To:	Ulf Hansson <ulf.hansson@...aro.org>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	linux-mmc <linux-mmc@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Chris Ball <chris@...ntf.net>,
	Tony Prisk <linux@...sktech.co.nz>
Subject: Re: [PATCH 33/35 linux-next] mmc: constify of_device_id array



> On 20 March 2015 at 09:56 Ulf Hansson <ulf.hansson@...aro.org> wrote:
>
>
> On 17 March 2015 at 10:49, Ulf Hansson <ulf.hansson@...aro.org> wrote:
> > On 16 March 2015 at 20:59, Fabian Frederick <fabf@...net.be> wrote:
> >> of_device_id is always used as const.
> >> (See driver.of_match_table and open firmware functions)
> >>
> >> Signed-off-by: Fabian Frederick <fabf@...net.be>
> >
> > Acked-by: Ulf Hansson <ulf.hansson@...aro.org>
>
> I realized that you might wanted me to pick this up and queue it
> through my mmc tree? Just tell me if that's what you want.
>
> Kind regards
> Uffe

Hi Ulf,

        Yes of course :) (it has not been added to linux-next yet).

Thanks,
Fabian
>
> >
> >> ---
> >>  drivers/mmc/host/mmc_spi.c   | 2 +-
> >>  drivers/mmc/host/wmt-sdmmc.c | 2 +-
> >>  2 files changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/mmc/host/mmc_spi.c b/drivers/mmc/host/mmc_spi.c
> >> index e4a0754..ae19d83 100644
> >> --- a/drivers/mmc/host/mmc_spi.c
> >> +++ b/drivers/mmc/host/mmc_spi.c
> >> @@ -1507,7 +1507,7 @@ static int mmc_spi_remove(struct spi_device *spi)
> >>         return 0;
> >>  }
> >>
> >> -static struct of_device_id mmc_spi_of_match_table[] = {
> >> +static const struct of_device_id mmc_spi_of_match_table[] = {
> >>         { .compatible = "mmc-spi-slot", },
> >>         {},
> >>  };
> >> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
> >> index dd2e1aa..5af0055 100644
> >> --- a/drivers/mmc/host/wmt-sdmmc.c
> >> +++ b/drivers/mmc/host/wmt-sdmmc.c
> >> @@ -744,7 +744,7 @@ static struct wmt_mci_caps wm8505_caps = {
> >>         .max_blk_size = 2048,
> >>  };
> >>
> >> -static struct of_device_id wmt_mci_dt_ids[] = {
> >> +static const struct of_device_id wmt_mci_dt_ids[] = {
> >>         { .compatible = "wm,wm8505-sdhc", .data = &wm8505_caps },
> >>         { /* Sentinel */ },
> >>  };
> >> --
> >> 2.1.0
> >>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/