linux-kernel - Re: [PATCH] net: dsa: make NET_DSA manually selectable from the config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550CCB67.5010008@roeck-us.net>
Date:	Fri, 20 Mar 2015 18:37:43 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	Mathieu Olivari <mathieu@...eaurora.org>, davem@...emloft.net,
	f.fainelli@...il.com, jiri@...nulli.us, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: dsa: make NET_DSA manually selectable from the config

On 03/20/2015 06:31 PM, Mathieu Olivari wrote:
> Change bd76a116707bd2381da36cf7c3183df11293f1d6 made all DSA drivers
> depend on NET_DSA rather than selecting them. However, as the only way
> to select this option was to actually select a driver, it made DSA
> impossible to enable at all.
>
> This patch adds an explicit entry which the user will have to enable
> prior selecting a driver.
>

Fixes: bd76a116707b ("dsa: change "select" to "depends on" for NET_SWITCHDEV and for NET_DSA")

> Signed-off-by: Mathieu Olivari <mathieu@...eaurora.org>

Andrew found the same problem yesterday and was about to submit
the same patch...

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   net/dsa/Kconfig | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/net/dsa/Kconfig b/net/dsa/Kconfig
> index 087e654..4f3cce1 100644
> --- a/net/dsa/Kconfig
> +++ b/net/dsa/Kconfig
> @@ -5,9 +5,12 @@ config HAVE_NET_DSA
>   # Drivers must select NET_DSA and the appropriate tagging format
>
>   config NET_DSA
> -	tristate
> +	tristate "Distributed Switch Architecture"
>   	depends on HAVE_NET_DSA && NET_SWITCHDEV
>   	select PHYLIB
> +	---help---
> +	  Say Y if you want to enable support for the hardware switches supported
> +	  by the Distributed Switch Architecture.
>
>   if NET_DSA
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/