linux-kernel - Re: [PATCH v10 00/21] Introduce ACPI for ARM64 based on ACPI 5.1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <550CE2CE.4080508@linaro.org>
Date:	Sat, 21 Mar 2015 11:17:34 +0800
From:	Hanjun Guo <hanjun.guo@...aro.org>
To:	Will Deacon <will.deacon@....com>,
	Hanjun Guo <guohanjun@...wei.com>
CC:	Catalin Marinas <Catalin.Marinas@....com>,
	"Rafael J. Wysocki" <rjw@...ysocki.net>,
	Olof Johansson <olof@...om.net>,
	"grant.likely@...aro.org" <grant.likely@...aro.org>,
	Lorenzo Pieralisi <Lorenzo.Pieralisi@....com>,
	Arnd Bergmann <arnd@...db.de>,
	Mark Rutland <Mark.Rutland@....com>,
	"graeme.gregory@...aro.org" <graeme.gregory@...aro.org>,
	Sudeep Holla <Sudeep.Holla@....com>,
	"jcm@...hat.com" <jcm@...hat.com>,
	Marc Zyngier <Marc.Zyngier@....com>,
	Mark Brown <broonie@...nel.org>,
	Robert Richter <rric@...nel.org>,
	Timur Tabi <timur@...eaurora.org>,
	Ashwin Chaugule <ashwinc@...eaurora.org>,
	"suravee.suthikulpanit@....com" <suravee.suthikulpanit@....com>,
	"linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linaro-acpi@...ts.linaro.org" <linaro-acpi@...ts.linaro.org>,
	Parth Dixit <parth.dixit@...aro.org>,
	'Stefano Stabellini' <stefano.stabellini@...citrix.com>
Subject: Re: [PATCH v10 00/21] Introduce ACPI for ARM64 based on ACPI 5.1

+CC Parth Dixit, Stefano Stabellini.

On 2015年03月21日 02:54, Will Deacon wrote:
> On Thu, Mar 19, 2015 at 04:09:33AM +0000, Hanjun Guo wrote:
>> On 2015/3/19 3:05, Will Deacon wrote:
>>> If you can get that in place, I'm not opposed to putting this into
>>> linux-next ahead of the firmware summit in San Jose next week. Note that
>>> this is not a commitment for 4.1, since I'm keen to see the outcomes of
>>> next week before setting anything in stone.
>>
>> OK, I will stick to this mailing list and respond as soon as I can.
>
> This doesn't even build for me:
>
>
> $ make ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- allmodconfig
> $ make ARCH=arm64 CROSS_COMPILE=aarch64-none-linux-gnu- Image
>
> [...]
>
> In file included from drivers/xen/acpi.c:33:0:

Sorry, I didn't build ACPI with XEN enabled on ARM64.

> include/xen/acpi.h: In function ‘xen_acpi_sleep_register’:
> include/xen/acpi.h:102:3: error: ‘acpi_suspend_lowlevel’ undeclared (first use in this function)
>     acpi_suspend_lowlevel = xen_acpi_suspend_lowlevel;

acpi_suspend_lowlevel is defined only for X86 and IA64 for now.

>     ^
> include/xen/acpi.h:102:3: note: each undeclared identifier is reported only once for each function it appears in
> drivers/xen/acpi.c: In function ‘xen_acpi_notify_hypervisor_state’:
> drivers/xen/acpi.c:61:2: error: implicit declaration of function ‘HYPERVISOR_dom0_op’ [-Werror=implicit-function-declaration]
>    HYPERVISOR_dom0_op(&op);

And this is only for x86:
./arch/x86/include/asm/xen/hypercall.h:HYPERVISOR_dom0_op(struct 
xen_platform_op *platform_op)

>    ^
> cc1: some warnings being treated as errors
> make[2]: *** [drivers/xen/acpi.o] Error 1
> make[2]: *** Waiting for unfinished jobs....
> make[1]: *** [drivers/xen] Error 2
> make[1]: *** Waiting for unfinished jobs....
> make: *** [drivers] Error 2
>
>
> Am I missing some other patches?

No, you miss nothing. Parth Dixit is still working on XEN ACPI for
ARM64, before it's in full function, how about introduce a Kconfig
CONFIG_XEN_ACPI and let it depends on x86? when XEN ACPI for ARM64
comes, we can enable ARM64 for CONFIG_XEN_ACPI and fix the problems
above.

Stefano, Parth, what do you think?

Thanks
Hanjun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/