linux-kernel - Re: [PATCH] checkpatch.pl: Add warning for harmful goto labels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150322121651.GA15680@bart.evergreen.loc>
Date:	Sun, 22 Mar 2015 13:16:51 +0100
From:	L. Alberto Giménez <agimenez@...valve.es>
To:	Joe Perches <joe@...ches.com>
Cc:	Richard Weinberger <richard@....at>,
	LKML <linux-kernel@...r.kernel.org>,
	Andy Whitcroft <apw@...onical.com>
Subject: Re: [PATCH] checkpatch.pl: Add warning for harmful goto labels

On Sat, Mar 21, 2015 at 07:56:39PM -0700, Joe Perches wrote:
> []
> > > If something is already in the kernel code, does that mean that it's OK?
> > > I honestly don't think so, and I think that goto labels for cleanup exit
> > > paths should be a little more descriptive.
> > 
> > I disagree. out and exit are perfectly fine labels.
> 
> I agree with you Richard.
> 
[...]
> > > It's just a proposal for a warning. If it is really not needed, it won't
> > > be applied and life will go on :)
> 
> In that case, it'd be nicer to preface the patch subject with RFC

Yes, you are right, sorry about that.

Thank you for the feedback guys!

And Richard, of course I was kidding about the 'i' variable. I enjoy
sarcasm myself too :)

Best regards,
-- 
L. Alberto Giménez
GnuPG key ID 0xDD4E27AB
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/