linux-kernel - Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201503221848.02226.arnd@linaro.org>
Date:	Sun, 22 Mar 2015 18:48:02 +0100
From:	Arnd Bergmann <arnd@...aro.org>
To:	Richard Cochran <richardcochran@...il.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Amir Vadai <amirv@...lanox.com>,
	Ariel Elior <ariel.elior@...gic.com>,
	Baolin Wang <baolin.wang@...aro.org>,
	Ben Hutchings <ben@...adent.org.uk>,
	Bruce Allan <bruce.w.allan@...el.com>,
	Carolyn Wyborny <carolyn.wyborny@...el.com>,
	Chris Metcalf <cmetcalf@...hip.com>,
	David Miller <davem@...emloft.net>,
	Frank Li <Frank.Li@...escale.com>,
	Giuseppe Cavallaro <peppe.cavallaro@...com>,
	Jeff Kirsher <jeffrey.t.kirsher@...el.com>,
	John Stultz <john.stultz@...aro.org>,
	Luwei Zhou <b45643@...escale.com>,
	Matthew Vick <matthew.vick@...el.com>,
	Michael Chan <mchan@...adcom.com>,
	Prashant Sreedharan <prashant@...adcom.com>,
	Shradha Shah <sshah@...arflare.com>,
	Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
	Sonic Zhang <sonic.zhang@...log.com>,
	Stefan Sørensen 
	<stefan.sorensen@...ctralink.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [PATCH net-next V2 20/23] ptp: dp83640: convert to the 64 bit get/set time methods.

On Sunday 22 March 2015, Richard Cochran wrote:
> On Sun, Mar 22, 2015 at 03:36:31AM +0100, Arnd Bergmann wrote:
> > On Saturday 21 March 2015, Richard Cochran wrote:
> > >         mutex_lock(&clock->extreg_lock);
> > >  
> > > -       err = tdr_write(1, phydev, ts, PTP_LOAD_CLK);
> > > +       err = tdr_write(1, phydev, &ts, PTP_LOAD_CLK);
> > >  
> > >         mutex_unlock(&clock->extreg_lock);
> > 
> > I don't see the change to the tdr_write() function that changes the 
> > argument from 'struct timespec ts' to 'struct timespec64 *', so this
> > looks wrong to me.
> 
> There is a 'ts64' parameter, converted to 'ts' beforehand.
> 

Ok, got it. The code looks correct then, though I'd like to see the use
of 'timespec' pushed out as far as possible. How about changing the
type for tdr_write() as well here?

tdr_write() itself should be fine until 2106, as it writes an unsigned number,
but it's probably good to document that inside of that function.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/