linux-kernel - [PATCH] xfs: Fix incorrect positive ENOMEM return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <1427051007.27543.21.camel@perches.com>
Date:	Sun, 22 Mar 2015 12:03:27 -0700
From:	Joe Perches <joe@...ches.com>
To:	Dave Chinner <david@...morbit.com>
Cc:	xfs <xfs@....sgi.com>, LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] xfs: Fix incorrect positive ENOMEM return

commit 5681ca40064f ("xfs: Remove icsb infrastructure")
incorrectly added a positive error return value.

This value filters up through the return layers
and should be negative as the other return values
are in the same function.

Signed-off-by: Joe Perches <joe@...ches.com>
---
 fs/xfs/xfs_super.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 3ad0b17..8782b36 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -1380,7 +1380,7 @@ xfs_init_percpu_counters(
 
 	error = percpu_counter_init(&mp->m_icount, 0, GFP_KERNEL);
 	if (error)
-		return ENOMEM;
+		return -ENOMEM;
 
 	error = percpu_counter_init(&mp->m_ifree, 0, GFP_KERNEL);
 	if (error)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/