linux-kernel - Re: [PATCH 1/2] of: handle both '/' and ':' in path strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAL_JsqKhiZ4iE+D9WcgSZNg5_N_vdf=ec0QooAn932+Q75Gokg@mail.gmail.com>
Date:	Sun, 22 Mar 2015 15:04:43 -0500
From:	Rob Herring <robh@...nel.org>
To:	Brian Norris <computersforpeace@...il.com>
Cc:	Peter Hurley <peter@...leysoftware.com>,
	Leif Lindholm <leif.lindholm@...aro.org>,
	stable <stable@...r.kernel.org>,
	Grant Likely <grant.likely@...aro.org>,
	Rob Herring <robh+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] of: handle both '/' and ':' in path strings

On Tue, Mar 17, 2015 at 2:30 PM, Brian Norris
<computersforpeace@...il.com> wrote:
> Commit 106937e8ccdc ("of: fix handling of '/' in options for
> of_find_node_by_path()") caused a regression in OF handling of
> stdout-path. While it fixes some cases which have '/' after the ':', it
> breaks cases where there is more than one '/' *before* the ':'.
>
> For example, it breaks this boot string
>
>   stdout-path = "/rdb/serial@...0ab00:115200";
>
> So rather than doing sequentialized checks (first for '/', then for ':';
> or vice versa), to get the correct behavior we need to check for the
> first occurrence of either one of them.
>
> It so happens that the handy strcspn() helper can do just that.
>
> Fixes: 106937e8ccdc ("of: fix handling of '/' in options for of_find_node_by_path()")
> Signed-off-by: Brian Norris <computersforpeace@...il.com>
> Cc: stable@...r.kernel.org

Thanks. Applied both and in Linus' tree now.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/