linux-kernel - Re: [PATCH 1/1] cifs: potential memory leaks when parsing mnt opts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFB9KM0fDCJ+gHcW0ZyNQdWhraGredJCdBT1AO0GqK4ibFEvYQ@mail.gmail.com>
Date:	Sat, 21 Mar 2015 22:54:58 -0500
From:	Scott Lovenberg <scott.lovenberg@...il.com>
To:	Taesoo Kim <taesoo@...ech.edu>
Cc:	Taesoo Kim <tsgatesv@...il.com>,
	"sfrench@...ba.org" <sfrench@...ba.org>,
	linux-cifs <linux-cifs@...r.kernel.org>,
	samba-technical@...ts.samba.org,
	LKML <linux-kernel@...r.kernel.org>, changwoo@...ech.edu,
	sanidhya@...ech.edu, blee@...ech.edu, csong84@...ech.edu
Subject: Re: [PATCH 1/1] cifs: potential memory leaks when parsing mnt opts

On Sat, Mar 21, 2015 at 10:23 PM, Taesoo Kim <taesoo@...ech.edu> wrote:
> On 03/21/15 at 09:10pm, Scott Lovenberg wrote:
>> On Sat, Mar 21, 2015 at 6:08 PM, Taesoo Kim <tsgatesv@...il.com> wrote:
>>
>> > Althouhg mkfs.cifs in userspace performs a bit of sanitization
>> > (e.g., forcing one user option), current implementation is not
>> > robust. Other options such as iocharset and domainanme are similary
>> > vulnerable.
>> >
>>
>> I assume you mean mount.cifs?  :-) Anyways, good catch.
>
> Right. FYI, I've tried mangling password field (e.g., pass=a,user=A
> &c); Skimming through the code (just a few minutes), there are a few
> potential places that don't sanitize its string, unlike passwd. But
> don't have much time to play with for now :)
>
> Thanks,
> Taesoo
>
>> --
>> Peace and Blessings,
>> -Scott.

Without even looking at the code, I can tell you that's probably my
fault if you're talking about the code in mount.cifs.  I was pretty
paranoid about the password field but not so paranoid about the other
parameters.  I'll take a look late tonight or some time tomorrow and
try to patch over my shame. :)

-- 
Peace and Blessings,
-Scott.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/