linux-kernel - Re: [Drbd-dev] [PATCH] drbd: use bitmap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAC5umyiWnqDT2EmhcaanZZKYtPoBgG5UzB2602sOO2sRNak3Ng@mail.gmail.com>
Date:	Sun, 22 Mar 2015 11:11:41 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Akinobu Mita <akinobu.mita@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, drbd-dev@...ts.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: use bitmap_weight()

2015-03-21 0:14 GMT+09:00 Lars Ellenberg <lars.ellenberg@...bit.com>:
> On Sat, Mar 14, 2015 at 10:12:56AM +0900, Akinobu Mita wrote:
>> Use bitmap_weight to count the total number of bits set in bitmap.
>> This change just simplifies the code a bit.
>
> "Simplifies", not sure about that, but ok, maybe.
>
> For the "bm_set_full_words_within_one_page", I disagree.
> I think it is more cpu cache friendly to hweight_long then set to ~0UL
> each word in turn, than to first bitmap_weight() all words, then
> bitmap_fill() all words.

I see. I'll remove the change in bm_set_full_words_within_one_page().

> Thanks,
>
>         Lars Ellenberg
>
> BTW, you swapped names and email addresses of phil and me.  Are those
> listed incorrectly somewhere, or was that just a mishap on your part?

It's just my mistake.  I copied your names from MAINTAINERS, but it
doesn't list your email addresses then I incorrectly swapped while
retrieving email addrsses from git log.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/