linux-kernel - Re: [PATCH][ASoC]Add ability to remove rate constraints from generic ASoC AC'97 CODEC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150322182744.GB6643@sirena.org.uk>
Date:	Sun, 22 Mar 2015 18:27:44 +0000
From:	Mark Brown <broonie@...nel.org>
To:	"Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Cc:	alsa-devel@...a-project.org, Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.de>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Brian Austin <brian.austin@...rus.com>,
	Bard Liao <bardliao@...ltek.com>,
	Oder Chiou <oder_chiou@...ltek.com>,
	Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][ASoC]Add ability to remove rate constraints from generic
 ASoC AC'97 CODEC driver

On Wed, Mar 11, 2015 at 12:28:19AM +0100, Maciej S. Szmigiero wrote:
> Add ability to remove rate constraints from generic ASoC AC'97 CODEC
> driver via passed platform data, make it selectable in config.

Please use subject lines matching the style for the subsystem.  This is
helpful for identifying relevant patches and not getting your messages
deleted unread...

> This way this driver can be used for platforms which don't need
> specialized AC'97 CODEC drivers while at the same avoiding
> code duplication from implementing equivalent functionality in
> a controller driver.

I'm sorry but this just doesn't explain what this patch is intended to
accomplish.  If we can talk to the AC'97 CODEC at all we can already
identify whatever constraints it has by looking at the ID registers so
it's not clear when or why a platform would need to use this.  It feels
like there is some underlying problem that you're trying to address.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)