linux-kernel - Re: [PATCH] ASoC:pcm512x: Make PLL lock output selectable via device tree.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Mar 2015 16:24:09 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Howard Mitchell <hm@...edded.co.uk>
Cc:	peda@...ntia.se, tiwai@...e.de, lgirdwood@...il.com,
	perex@...ex.cz, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, devicetree@...r.kernel.org,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC:pcm512x: Make PLL lock output selectable via device
 tree.

On Fri, Mar 20, 2015 at 09:22:43PM +0000, Howard Mitchell wrote:

> +	if (pcm512x->pll_lock) {

> +                if (of_property_read_u32(np, "pll-lock", &val) >= 0) {
> +                        if (val > 6) {
> +                                dev_err(dev, "Invalid pll-lock\n");
> +                                ret = -EINVAL;
> +                                goto err_clk;
> +                        }
> +                        pcm512x->pll_lock = val;
> +                }

This breaks existing boards which rely on GPIO 4 being set as the lock
output.  This is very unfortunate since it's a silly thing for the
driver to default to but nontheless we should really continue to support
them - at a guess Peter's board is relying on this, and even if it isn't
someone else's might.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)