linux-kernel - Re: [PATCH] perf tools: Remove (null) value of "Sort order" for perf mem report

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150323004433.GD2782@sejong>
Date:	Mon, 23 Mar 2015 09:44:33 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Yunlong Song <yunlong.song@...wei.com>
Cc:	a.p.zijlstra@...llo.nl, paulus@...ba.org, mingo@...hat.com,
	acme@...nel.org, linux-kernel@...r.kernel.org, wangnan0@...wei.com
Subject: Re: [PATCH] perf tools: Remove (null) value of "Sort order" for perf
 mem report

Hi Yunlong,

On Thu, Mar 19, 2015 at 09:58:32PM +0800, Yunlong Song wrote:
> When '--sort' is not set, 'perf mem report" will print a null pointer as
> the output value of sort order, so fix it.
> 
> Example:
> 
> Before this patch:
> 
>  $ perf mem report
>  # To display the perf.data header info, please use --header/--header-only options.
>  #
>  # Samples: 18  of event 'cpu/mem-loads/pp'
>  # Total weight : 188
>  # Sort order   : (null)
>  #
>  ...
> 
> After this patch:
> 
>  $ perf mem report
>  # To display the perf.data header info, please use --header/--header-only options.
>  #
>  # Samples: 18  of event 'cpu/mem-loads/pp'
>  # Total weight : 188
>  #
>  ...

I think it'd be better to show default sort order in this case.


> 
> Signed-off-by: Yunlong Song <yunlong.song@...wei.com>
> ---
>  tools/perf/builtin-report.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 52f74e1..918ffef 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -304,7 +304,8 @@ static size_t hists__fprintf_nr_sample_events(struct hists *hists, struct report
>  
>  	if (rep->mem_mode) {
>  		ret += fprintf(fp, "\n# Total weight : %" PRIu64, nr_events);
> -		ret += fprintf(fp, "\n# Sort order   : %s", sort_order);
> +		if (sort_order)
> +			ret += fprintf(fp, "\n# Sort order   : %s", sort_order);

Something like this?

		ret += fprintf(fp, "\n# Sort order   : %s", sort_order ?: default_mem_sort_order);

Thanks,
Namhyung


>  	} else
>  		ret += fprintf(fp, "\n# Event count (approx.): %" PRIu64, nr_events);
>  	return ret + fprintf(fp, "\n#\n");
> -- 
> 1.8.5.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/